Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 1244/create data studio command #479

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

endre-seqera
Copy link
Member

@endre-seqera endre-seqera commented Jan 28, 2025

Description

Closes https://seqera.atlassian.net/browse/PLAT-1244

Testing

➜ ./gradlew run -q --args="studios templates -w 27230932650799"

  Available templates for Data Studios:

     Templates                                                 
    -----------------------------------------------------------
     cr.seqera.io/public/data-studio-jupyter:4.2.5-snapshot    
     cr.seqera.io/public/data-studio-rstudio:4.4.1-u1-snapshot 
     cr.seqera.io/public/data-studio-vscode:1.93.1-snapshot    
     cr.seqera.io/public/data-studio-xpra:6.2.0-r2-1-snapshot  

➜ ./gradlew run -q --args="studios add -n my-2nd-studio-created-with-cli -w 27230932650799 -t cr.seqera.io/public/data-studio-vscode:1.93.1-snapshot -c 7WgvfmcjAwp3Or75UphCJl"

  Data Studio d1fd1f90 CREATED at [data-studios / data-studios] workspace.

➜ ./gradlew run -q --args="studios add -n my-studio-created-with-cli -w 27230932650799 -t cr.seqera.io/public/data-studio-vscode:1.93.1-snapshot -c 7WgvfmcjAwp3Or75UphCJl -a --wait running"

  Data Studio 75463612 CREATED at [data-studios / data-studios] workspace and auto started.

  Waiting running status....
  Status transitioned to: starting
  Provisioning compute resources.......
  Status transitioned to: errored
  Provisioning compute resources - Error encountered: JobQueue TowerForge-2rZkbXfTkiJxTVz18OJs3i not found.

➜ ./gradlew run -q --args="--insecure studios start-as-new -pid 7947d799 -n my-1st-start-as-new -w 22117901918827 --cpu 4"

  Data Studio 96cf66d4 CREATED at [aaa / bbb] workspace.

➜ ./gradlew run -q --args="--insecure studios start-as-new -pid 47834467 -n my-6th -w 22117901918827 -a --wait running"

  Data Studio c5364a0a CREATED at [aaa / bbb] workspace and auto started.

  Waiting running status....
  Status transitioned to: starting
  Provisioning compute resources...
  Status transitioned to: errored
  Provisioning compute resources - Error encountered: JobQueue TowerForge-2rZkbXfTkiJxTVz18OJs3i not found.

@endre-seqera endre-seqera force-pushed the plat-1244/create-data-studio-command branch from a0d4cd3 to 3336496 Compare January 28, 2025 14:21
@endre-seqera endre-seqera marked this pull request as ready for review January 28, 2025 14:21
Copy link
Contributor

@t0randr t0randr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should restore the interrupt flag of the thread though.

Copy link
Contributor

@georgi-seqera georgi-seqera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good 👍

@endre-seqera endre-seqera merged commit b406210 into master Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants