Skip to content

Conversation

@gavinelder
Copy link
Contributor

The following is documenting our supported method for bottle rocket after customer feedback that they ran into issues making this work until they found the upstream buildkit documentation.

https://github.com/moby/buildkit/blob/master/docs/rootless.md#bottlerocket-os

@gavinelder
Copy link
Contributor Author

@christopher-hakkaart I would like some documentation help on this one.

The specific node configuration is not something I want us to deep-dive on there are lots of official documentation examples around to handle this and it will be dependent on how an end-user has setup their cluster and their internal security policies.

@gavinelder gavinelder requested a review from gwright99 September 3, 2025 11:37
@gavinelder
Copy link
Contributor Author

@gwright99 your input here would be beneficial from the eyes of the customer internally we are using the user-data approach but have tested and validated the daemonset and selectors also work.

@christopher-hakkaart
Copy link
Member

@christopher-hakkaart I would like some documentation help on this one.

I'll start working on this today and will tag you for comment/review when it's getting close to being ready 👍

@christopher-hakkaart
Copy link
Member

christopher-hakkaart commented Sep 3, 2025

I've made some changes to align the language with the style guide. I changed heading levels so it didn't fall under troubleshooting, but I kept the H4 headings so they didn't clutter the RHS navigation, and remain linkable.

I didn't add anything extra from the FAQs you linked; instead, I added an Additional resources section with the links you provided. If this is insufficient, let me know, and I can add more context/information/links.

Broadly, I'm not sure if this belongs under Install > Configure Wave build. It might be better as an under Configuration > Configure Wave. I have a PR in development to tidy these sections anyway, so I'm fine with this for now.

@gavinelder
Copy link
Contributor Author

This is awesome thanks for this fix up

@gavinelder gavinelder marked this pull request as ready for review September 4, 2025 22:17
Copy link
Member

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - I've approved, but let's wait for @gwright99 to check as well

Copy link

@gwright99 gwright99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dealbreakers here, just a few comments on sections that might benefit from a bit more context/information.


#### Alternative: DaemonSet

If you can't control the node configuration directly, use DaemonSet. This approach requires running a privileged container. We recommend you deploy it only on wave-build nodes and use a dedicated namespace for isolation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a known scenario where the preferred option won't be available and the DS workaround will be needed?

@christopher-hakkaart
Copy link
Member

Let's get this out

@christopher-hakkaart christopher-hakkaart merged commit 36c4b42 into master Oct 24, 2025
1 check passed
@christopher-hakkaart christopher-hakkaart deleted the docs/buildkit-support branch October 24, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants