-
Notifications
You must be signed in to change notification settings - Fork 7
docs: buildkit on bottlerocket support #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@christopher-hakkaart I would like some documentation help on this one. The specific node configuration is not something I want us to deep-dive on there are lots of official documentation examples around to handle this and it will be dependent on how an end-user has setup their cluster and their internal security policies. |
|
@gwright99 your input here would be beneficial from the eyes of the customer internally we are using the user-data approach but have tested and validated the daemonset and selectors also work. |
I'll start working on this today and will tag you for comment/review when it's getting close to being ready 👍 |
|
I've made some changes to align the language with the style guide. I changed heading levels so it didn't fall under troubleshooting, but I kept the H4 headings so they didn't clutter the RHS navigation, and remain linkable. I didn't add anything extra from the FAQs you linked; instead, I added an Additional resources section with the links you provided. If this is insufficient, let me know, and I can add more context/information/links. Broadly, I'm not sure if this belongs under Install > Configure Wave build. It might be better as an under Configuration > Configure Wave. I have a PR in development to tidy these sections anyway, so I'm fine with this for now. |
|
This is awesome thanks for this fix up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - I've approved, but let's wait for @gwright99 to check as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No dealbreakers here, just a few comments on sections that might benefit from a bit more context/information.
|
|
||
| #### Alternative: DaemonSet | ||
|
|
||
| If you can't control the node configuration directly, use DaemonSet. This approach requires running a privileged container. We recommend you deploy it only on wave-build nodes and use a dedicated namespace for isolation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a known scenario where the preferred option won't be available and the DS workaround will be needed?
|
Let's get this out |
The following is documenting our supported method for bottle rocket after customer feedback that they ran into issues making this work until they found the upstream buildkit documentation.
https://github.com/moby/buildkit/blob/master/docs/rootless.md#bottlerocket-os