Skip to content

Conversation

@munishchouhan
Copy link
Member

This PR will do the following:

  1. Fix posix permission issue in singulairty build when untar layers
  2. Fix posix permission issue when untar context

@munishchouhan munishchouhan self-assigned this Sep 4, 2025
@munishchouhan munishchouhan marked this pull request as draft September 4, 2025 15:45
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
@pditommaso
Copy link
Collaborator

I think this can be simplified without handling in a special case the saving of build context and layers for singularity

if(req.formatDocker()) {
saveLayersToDockerContext0(req, contextDir)
}
else if(req.formatSingularity()) {
saveLayersToSingularityContext0(req, contextDir)
}
else
throw new IllegalArgumentException("Unknown container format: $req.format")

In both cases, Wave should only take case of saving the tar in the build work dir (s3 path). then mounting that path in the content. Finally Dockerfile add it/them to the container using one or more ADD, instead singularity using a %post script to untar and copy in the right directory

Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan
Copy link
Member Author

Tested singularity in dev:
https://wave.dev-seqera.io/view/builds/bd-f3d0dbf41f09b917_1

@munishchouhan
Copy link
Member Author

tested docker with context
https://wave.dev-seqera.io/view/containers/5f81208b7fae

Signed-off-by: munishchouhan <[email protected]>
@munishchouhan
Copy link
Member Author

tested singulairty with context
https://wave.dev-seqera.io/view/builds/bd-553d7de13471d357_1

@munishchouhan munishchouhan marked this pull request as ready for review September 9, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants