-
Notifications
You must be signed in to change notification settings - Fork 7
Support adding layers and context to container build #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
|
I think this can be simplified without handling in a special case the saving of build context and layers for singularity wave/src/main/groovy/io/seqera/wave/service/builder/impl/ContainerBuildServiceImpl.groovy Lines 272 to 279 in 3471824
In both cases, Wave should only take case of saving the tar in the build work dir (s3 path). then mounting that path in the content. Finally Dockerfile add it/them to the container using one or more |
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
|
Tested singularity in dev: |
Signed-off-by: munishchouhan <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
|
tested docker with context |
Signed-off-by: munishchouhan <[email protected]>
|
tested singulairty with context |
Signed-off-by: munishchouhan <[email protected]>
This PR will do the following: