Skip to content

Conversation

@christopher-hakkaart
Copy link
Member

@christopher-hakkaart christopher-hakkaart commented Sep 30, 2025

  • Add Wave api rate limit guide

Netlify preview is here: https://deploy-preview-845--seqera-docs.netlify.app/wave/nextflow/reduce-api-calls

Note: I don't love the location in the sidebar, but I think it's acceptable while we consider how guides might be presented in the docs moving forward.

- Lowest latency for AWS workloads
- Simplest setup

**Not recommended**: Private Docker Hub for AWS Batch workloads

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? Let's give them a reason (i.e. requires tinkering with Batch instances to authenticate to non-ECR registry).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see you did it below. nevermind.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be tempted to generalise it to say "use the native cloud container registry", which has all the same benefits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've softened to "Not recommended: External container registries for AWS Batch workloads" as per your other suggestion.

Are you suggesting we don't specifically call out AWS? And just refer to "native cloud container registries" instead of "AWS Batch workloads" for both recommended and not recommended?

Copy link

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bit more precision around the language of manfiest vs layers, and when you access the Wave service.

- Lowest latency for AWS workloads
- Simplest setup

**Not recommended**: Private Docker Hub for AWS Batch workloads

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be tempted to generalise it to say "use the native cloud container registry", which has all the same benefits.

@christopher-hakkaart
Copy link
Member Author

Thanks everyone - sorry for all the noise on the PR.

I've made the suggested changes, and a larger restructure after Adams' comments made me realize we had sections that were largely similar (Building without Wave freeze, Building with Wave freeze, First pipeline run, and Subsequent pipeline runs).

This has now been shaped into two sections (Building without Wave freeze and Building with Wave freeze).

There are two open comments.

Copy link

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Some clarification around definitions and what counts against what.

@christopher-hakkaart christopher-hakkaart marked this pull request as ready for review October 8, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants