Clean up permissions.rs #3046
Merged
Clean up permissions.rs #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnomedDev
force-pushed
the
permissions-cleanup
branch
from
ec84741
to
0588329
Compare
|
I can confirm this works |
jamesbt365
approved these changes
Nov 18, 2024
arqunis
approved these changes
Nov 18, 2024
DovidP
added a commit
to scopeclient/serenity
that referenced
this pull request
Nov 19, 2024
Clean up permissions.rs (serenity-rs#3046)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the
bitflagsandgenerate_permission_namesmacros into a single macro, which also generates the shorthand methods. The first commit in this PR is the actual change but with weird formatting to make it nicer to diff, and the second commit fixes that formatting.This should make no user-facing diff, except from fixing missing entries in
get_permission_names.