-
Notifications
You must be signed in to change notification settings - Fork 626
Add support for Label and File Upload components #3430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
10b2fe1
to
a222708
Compare
a222708
to
0101a40
Compare
Why remove |
The |
Wasn't that the point of |
8eeab73
to
066e551
Compare
066e551
to
049e52a
Compare
I've gone ahead and also added support for the new File Upload component, as it can only be found inside a Label.
I didn't realize it was a ZST, however I do still think that for now, |
Labels are a new top-level component only supported in modals that can hold a Text Input, Select Menu, or File Upload (another new component) inside it. Oddly enough, the label and description are removed from the label payload when sent back as part of a modal response. See the docs.
Text Inputs inside Action Rows are deprecated, therefore I removed the
InputText
variant forActionRowComponent
. Also, at the moment modals can include Action Rows, Text Displays, and Labels as top-level components, so I changed modal responses to storeComponent
instead ofActionRow
and added atext
method to quick modals. I thought about adding select menu support to quick modals but the methods felt a little too verbose.