Add nonce prop to ExternalScripts
#448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnemitz
force-pushed
the
add-nonce-external-scripts
branch
from
07af8ed to
1377f09
Compare
Contributor
Author
|
@sergiodxa Any thoughts on this? 🙂 |
|
@sergiodxa - any chance of this getting added? I recently ran into this same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for a
noncevalue to be passed to theExternalScriptscomponent (similarly to theScriptscomponent from@remix-run/react) in order to comply with thescriptSrcdirective of the page's CSP.The rationale for allowing this prop specifically is that the
noncevalue is not practical to set in theExternalScriptHandleitself, as it is generated per-request.Happy to discuss if there's a different recommended way of achieving this :)