-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.0-alpha #188
Draft
JBBianchi
wants to merge
22
commits into
serverlessworkflow:main
Choose a base branch
from
neuroglia-io:v1.0.0-alpha
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
v1.0.0-alpha #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed organisation and package name - updated maintainers - removed previous code items - updated tools Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
I think the branch reached a mature enough state for code review. The README has been updated to match the new API and I added a Tooling Architecture document to describe how the SDK is built. Any input or help is welcome ❤️ |
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Prevents accessing a property which is declared in one type but not the other: ``` type A = { p: string; }; type B = { k: number; }; const foo = {} as A | B; foo.p = "bar"; //>Property 'p' does not exist on type 'A | B'. //> Property 'p' does not exist on type 'B'. ``` Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
…t in the tooling Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
JBBianchi
force-pushed
the
v1.0.0-alpha
branch
from
September 12, 2024 10:14
e7e49d5
to
6c040e0
Compare
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
JBBianchi
force-pushed
the
v1.0.0-alpha
branch
from
September 12, 2024 10:16
6c040e0
to
fe3bbee
Compare
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Allows to validate an item against the workflow, for instance a transition, the use of a a function, ... Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Support for v1.0.0-alpha (#186)
Special notes for reviewers:
Type generation for schema is very unstable, a small change in the spec can have a big impact on the generated types and underlying validators, classes and builders.
Classes are empty. It's just a trick to maybe have some kind of runtime type checking (see builders tests).
Additional information (if needed):
Currently uses a manually modified version of the spec's JSON Schema. Yield completely different results otherwise.