Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transitions issues in the Dashboard graph #472

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Fixed an issue in the graph where the transition of a conditional node was followed instead of skipped
  • Fixed an issue in the graph where an exit or end transition in a switch case would result in an error
  • Added an icon to "custom function" nodes

- Fixed an issue in the graph where the transition of a conditional node was followed instead of skipped
- Fixed an issue in the graph where an exit or end transition in a switch case would result in an error
- Added an icon to "custom function" nodes

Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
@JBBianchi JBBianchi added app: dashboard Concerns the Dashboard UI priority: medium Indicates an average priority issue weight: 1 An issue that has a very low development impact type: fix labels Dec 18, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Dec 18, 2024
@JBBianchi JBBianchi requested a review from cdavernas December 18, 2024 15:09
@JBBianchi JBBianchi self-assigned this Dec 18, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks man!

@cdavernas cdavernas merged commit f500741 into main Dec 18, 2024
2 checks passed
@cdavernas cdavernas deleted the fix-dashboard-graph-transitions branch December 18, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: dashboard Concerns the Dashboard UI priority: medium Indicates an average priority issue type: fix weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants