Skip to content

Fix incorrect EnumMember value for Yaml #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

aweng126
Copy link
Contributor

Fix incorrect EnumMember value for Yaml

The EnumMember value for 'Yaml' was incorrectly set to 'json'. This PR fixes it to 'yaml' for correct serialization/deserialization.

Fixes #496

@JBBianchi
Copy link
Member

Thanks for your contribution @aweng126 , good catch!

However, signing-off the commits is mandatory for the PR to be merged. Could you please proceed ?

@aweng126
Copy link
Contributor Author

aweng126 commented Feb 24, 2025

@cdavernas @JBBianchi please review the new commit.

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas merged commit eb26e52 into serverlessworkflow:main Feb 24, 2025
2 checks passed
@aweng126 aweng126 deleted the fix-enum-value branch February 24, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: runner Concerns the Runner type: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnumMember Value for 'Yaml' is Incorrect
3 participants