Skip to content

Tendril: fix warnings, lints and upgrade to edition 2021 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 9, 2025
Merged

Tendril: fix warnings, lints and upgrade to edition 2021 #665

merged 22 commits into from
Sep 9, 2025

Conversation

nicoburns
Copy link
Contributor

Updates the tendril crate:

  • Fixes all warnings
  • Fixes simple clippy lints. Those for which the fix is more involved (or has risk of causing breakage) have been left for later.
  • Upgrades edition to 2021

@nicoburns
Replace transmute with char::from_u32:unchecked
913bef6 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix bare_trait_objects warning
a92209a 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::useless_conversions
2ebfb58 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::borrow_deref_ref
095dc21 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::legacy_numeric_constants
4164eec 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::map_clone
fe8bb7d 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::needless_lifetimes
5c47c30 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::explicit_auto_deref
011446e 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::len_zero
2595a00 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::match_like_matches_macro
141af1d 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::needless_return
81377f8 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::while_let_loop
a447708 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::redundant_field_names
73e96ab 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::redundant_static_lifetimes
af32e29 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::needless_late_init
94869ab 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::op_ref
7ccd9da 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Remove clippy::manual_repeat_n
90fb801 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::ptr_offset_with_cast
2b91464 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy::partialeq_ne_impl
1569087 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Remove commented code in benchmark
eb3a81c 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Upgrade tendril to Edition 2021
bf5ab20 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix clippy lints in tendril fuzz example
b6a20cf 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns nicoburns added this pull request to the merge queue Sep 9, 2025
Merged via the queue into servo:main with commit d242885 Sep 9, 2025
6 checks passed
@nicoburns nicoburns mentioned this pull request Sep 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoburns @mrobinson