Skip to content

Commit

Permalink
Properly mark failed CI as failing
Browse files Browse the repository at this point in the history
There was a syntax error in `if` condition for the `Result` CI job.
This meant that when a dependent job failed, the CI pipeline did not.
This should fix branch protection for the merge queue.
  • Loading branch information
mrobinson committed Aug 17, 2023
1 parent 5f69bbe commit 153996c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,12 @@ jobs:
build_result:
name: Result
runs-on: ubuntu-latest
# Integrity check is broken for the time being; don't require it.
needs: ["mac", "linux", "windows"]
if: ${{ always() }}
steps:
- name: Mark the job as successful
run: exit 0
if: success()
if: ${{ success() }}
- name: Mark the job as unsuccessful
run: exit 1
if: "!success()"
if: ${{ !success() }}

0 comments on commit 153996c

Please sign in to comment.