Skip to content

Commit

Permalink
Disable the integrity check on CI (#371)
Browse files Browse the repository at this point in the history
This is currently broken and it isn't going to be simple to fix.
Disabling this is better than always failing.
  • Loading branch information
mrobinson authored Aug 17, 2023
1 parent ba1ea1d commit aa6b120
Showing 1 changed file with 23 additions and 19 deletions.
42 changes: 23 additions & 19 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,25 +102,29 @@ jobs:
shell: cmd
run: |
cargo test --verbose ${{ matrix.features }}
Integrity:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Get mozjs
run: |
bash ./mozjs/etc/get_mozjs.sh
- name: Apply patch
run: |
python3 ./mozjs/etc/update.py --no-commit mozjs.tar.xz
# Run `git add` here to force CRLF converted into LF
# so that we can check diff properly in next run
git add --all mozjs
- name: Check patch integrity
working-directory: ./mozjs
# Because we've added files in previous run, we need to
# check diff with `--staged`.
run: |
git diff --staged --no-ext-diff --quiet --exit-code
# The integrity check is currently broken. See issue #345.
#
# Integrity:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
# - name: Get mozjs
# run: |
# bash ./mozjs/etc/get_mozjs.sh
# - name: Apply patch
# run: |
# python3 ./mozjs/etc/update.py --no-commit mozjs.tar.xz
# # Run `git add` here to force CRLF converted into LF
# # so that we can check diff properly in next run
# git add --all mozjs
# - name: Check patch integrity
# working-directory: ./mozjs
# # Because we've added files in previous run, we need to
# # check diff with `--staged`.
# run: |
# git diff --staged --no-ext-diff --quiet --exit-code

build_result:
name: Result
runs-on: ubuntu-latest
Expand Down

0 comments on commit aa6b120

Please sign in to comment.