Run CI only on master in upstream but everywhere in forks #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
reviewed
Aug 17, 2023
mrobinson
approved these changes
Aug 17, 2023
mrobinson
added a commit
that referenced
this pull request
Aug 17, 2023
This is essentially a revert of #369. It seems that skipping this workflow for merge queue branches is causing PRs to merge without any testing. See https://github.com/servo/mozjs/actions/runs/5893101692 It's simply too finicky to maintain an upstream and downstream mode in the same workflow when using the merge queue unfortunately.
This was referenced Aug 17, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
This is essentially a revert of #369. It seems that skipping this workflow for merge queue branches is causing PRs to merge without any testing. See https://github.com/servo/mozjs/actions/runs/5893101692 It's simply too finicky to maintain an upstream and downstream mode in the same workflow when using the merge queue unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes my life easier when testing changes.