Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cssparser_color version. #395

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Bump cssparser_color version. #395

merged 1 commit into from
Nov 7, 2024

Conversation

emilio
Copy link
Member

@emilio emilio commented Nov 7, 2024

No description provided.

@emilio emilio requested a review from mrobinson November 7, 2024 17:21
@emilio emilio mentioned this pull request Nov 7, 2024
Closed
nicoburns
nicoburns requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@nicoburns nicoburns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be a 0.2.0 release because the cssparser version bump was a semver incompatible version bump (as far as cargo is concerned), and there are cssparser types in the public API of cssparser_color.

@emilio
Copy link
Member Author

emilio commented Nov 7, 2024

I think this needs to be a 0.2.0 release because the cssparser version bump was a semver incompatible version bump (as far as cargo is concerned), and there are cssparser types in the public API of cssparser_color.

Nice catch, thanks!

@emilio emilio requested a review from nicoburns November 7, 2024 18:07
@nicoburns nicoburns added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 6fb149b Nov 7, 2024
11 checks passed
@emilio emilio deleted the bump-color branch November 7, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

@mrobinson mrobinson Awaiting requested review from mrobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilio @nicoburns