Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --locked when building in CI #20

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Use --locked when building in CI #20

merged 1 commit into from
Mar 16, 2024

Conversation

Loirooriol
Copy link
Contributor

Thus the build will fail if a PR modifies Cargo.toml but forgets to include the changes in Cargo.lock

@Loirooriol
Copy link
Contributor Author

See https://doc.rust-lang.org/cargo/commands/cargo-build.html#manifest-options

@Loirooriol
Use --locked when building in CI
936207e 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
@Loirooriol
Copy link
Contributor Author

Loirooriol commented Mar 16, 2024 •
edited
Loading

Works as expected:

@Loirooriol Loirooriol added this pull request to the merge queue Mar 16, 2024
Merged via the queue into servo:main with commit 2c775e4 Mar 16, 2024
3 checks passed
@Loirooriol Loirooriol deleted the ci-build-locked branch March 16, 2024 21:25
Loirooriol added a commit that referenced this pull request Mar 16, 2024
@Loirooriol
Use --locked when building in CI (#20)
8d29e4f 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
@Loirooriol Loirooriol mentioned this pull request Mar 17, 2024
Merged
3 tasks
Loirooriol added a commit that referenced this pull request Mar 29, 2024
@Loirooriol
Use --locked when building in CI (#20)
f734794 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Apr 9, 2024
@Loirooriol
Use --locked when building in CI (#20)
4a76a97 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Apr 13, 2024
@Loirooriol
Use --locked when building in CI (#20)
9b4baf0 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Apr 15, 2024
@Loirooriol
Use --locked when building in CI (#20)
996cc81 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Apr 22, 2024
@Loirooriol
Use --locked when building in CI (#20)
5f836cd 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request May 21, 2024
@Loirooriol
Use --locked when building in CI (#20)
da340e9 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Jun 11, 2024
@Loirooriol
Use --locked when building in CI (#20)
4565a3b 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Jun 24, 2024
@Loirooriol
Use --locked when building in CI (#20)
9554a17 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Loirooriol added a commit that referenced this pull request Jun 24, 2024
@Loirooriol
Use --locked when building in CI (#20)
7ef96ea 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
mrobinson pushed a commit that referenced this pull request Jun 25, 2024
@Loirooriol @mrobinson
Use --locked when building in CI (#20)
22fbe57 
Thus the build will fail if a PR modifies Cargo.toml but forgets to
include the changes in Cargo.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@mrobinson mrobinson Awaiting requested review from mrobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Loirooriol @jdm