-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servo: Add support for parsing :is()
and :where()
#80
base: main
Are you sure you want to change the base?
servo: Add support for parsing :is()
and :where()
#80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We've done this in Blitz and it seems to work. My one reservation would be that I believe that "nth-child" and "has" require extra invalidation logic that is not handled by Stylo and needs to be handled externally.
(I am keen to document how that works, probably as an example in the Stylo repo, but I haven't worked it out myself yet)
Yeah have you confirmed that |
It's functional, but there's still work to do with invalidation, as @nicoburns mentioned above. |
Should this be closed like servo/servo#33543 ? |
I think this should be scoped down. I believe |
d9db974
to
c2f7754
Compare
Stylo supports these and they just need to be turned on. Signed-off-by: Martin Robinson <[email protected]>
c2f7754
to
3e44b02
Compare
:is()
, :has()
, :where()
, and nesting selectors:is()
and :where()
Stylo supports these and they just need to be turned on.
Signed-off-by: Martin Robinson [email protected]