Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request openxr shutdown on quit #49

Merged
merged 1 commit into from
Sep 1, 2019
Merged

request openxr shutdown on quit #49

merged 1 commit into from
Sep 1, 2019

Conversation

paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Aug 30, 2019 •
edited
Loading

This will end the openxr session (back to 2D view in the case of HoloLens).

It's still missing the call to session.end() (see #47).

Fix #48

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit ff2a5a6 has been approved by Manishearth

@bors-servo
Copy link
Contributor

⌛ Testing commit ff2a5a6 with merge 932575d...

bors-servo pushed a commit that referenced this pull request Sep 1, 2019
Auto merge of #49 - paulrouget:openxrquit, r=Manishearth
932575d 
request openxr shutdown on quit

This will end the openxr session (back to 2D view in the case of HoloLens).

It's still missing the call to `session.end()` (see #47).

Fix #48
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing 932575d to master...

@bors-servo bors-servo merged commit ff2a5a6 into servo:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAF called after quit
3 participants
@paulrouget @Manishearth @bors-servo