More shutdown event processing #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrouget
force-pushed
the
shutdown
branch
from
5e61da8
to
7d667e0
Compare
|
@Manishearth r? |
|
@bors-servo r+ i feel like we're jumping between designs here, but really the solution is to do #30 so whatever works best for now is fine |
|
📌 Commit 7d667e0 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 24, 2019
More shutdown event processing This fixes 2 different crashes at shutdown. The initial approach of checking if session was running, then call RAF would fail as we would call `is_running()` before processing the event. I got rid of the `is_running()` mechanic and instead made `wait_for_animation_frame` return an Option. Assuming that returning None mean the session has ended. Fix #47
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 different crashes at shutdown.
The initial approach of checking if session was running, then call RAF would fail as we would call
is_running()before processing the event.I got rid of the
is_running()mechanic and instead madewait_for_animation_framereturn an Option. Assuming that returning None mean the session has ended.Fix #47