feat: consistently sorted maps for better change tracking #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the usages of HashMap with IndexMap for the outputs of "file_stems", "file_suffixes", and "file_icons". Leaves the original hashmap step in place but adds an additional Vec step where all the entries are added then sorted by key before being inserted into an IndexMap (which maintains the sort order) This ensures that a consistent order is maintained when producing the outputs, this way when creating releases for the beared-icon-theme.json file instead of a seeing a very large set of changes in the git output (Because of the hashmap key order changing) you'll now instead see only diffs for the parts that have actually changed, making it more clear what's changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the usages of HashMap with IndexMap for the outputs of "file_stems", "file_suffixes", and "file_icons". Leaves the original hashmap step in place but adds an additional Vec step where all the entries are added then sorted by key before being inserted into an IndexMap (which maintains the sort order)
This ensures that a consistent order is maintained when producing the outputs, this way when creating releases for the
beared-icon-theme.jsonfile instead of a seeing a very large set of changes in the git output (Because of the hashmap key order changing) you'll now instead see only diffs for the parts that have actually changed, making it more clear what's changedChanges