Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify implementation of polyhedra #87

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

severinstrobl
Copy link
Owner

No description provided.

@severinstrobl severinstrobl force-pushed the unify_polyhedra branch 3 times, most recently from 4398300 to f63a1b9 Compare March 24, 2024 15:03
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 89.35065% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 91.85%. Comparing base (ad9bde3) to head (a81983f).
Report is 39 commits behind head on develop.

Files Patch % Lines
include/overlap/overlap.hpp 89.35% 12 Missing and 29 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #87      +/-   ##
===========================================
- Coverage    93.30%   91.85%   -1.46%     
===========================================
  Files            1        1              
  Lines          851      908      +57     
  Branches       156      173      +17     
===========================================
+ Hits           794      834      +40     
- Misses          10       16       +6     
- Partials        47       58      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

C++ benchmark results

Benchmark Reference (bfc27d6) Current (3cd9170)
hex_overlap_volume 3.04 us 3.28 us: 1.08x slower
hex_overlap_volume_aabb 8.38 ns 7.14 ns: 1.17x faster
tet_overlap_volume 1.28 us 1.67 us: 1.30x slower
tet_overlap_volume_aabb 5.57 ns 4.98 ns: 1.12x faster
Geometric mean (ref) 1.01x slower

Benchmark hidden because not significant (2): normal_newell, regularized_wedge

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant