Fix some types of warnings #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedLyngmo
force-pushed
the
fix_some_warnings
branch
from
b742365
to
56ab298
Compare
sewenew
reviewed
Apr 29, 2022
sewenew
requested changes
May 1, 2022
TedLyngmo
force-pushed
the
fix_some_warnings
branch
from
56ab298
to
58af004
Compare
Also added a few warning options to the build: -Wshadow -Wconversion -Wcast-qual -Wsign-conversion can also be added if the below pull request is approved: redis/hiredis#1064 Signed-off-by: Ted Lyngmo <[email protected]>
TedLyngmo
force-pushed
the
fix_some_warnings
branch
from
58af004
to
f58f50e
Compare
sewenew
approved these changes
May 2, 2022
There was a problem hiding this comment.
@TedLyngmo Thanks for contribution!
However, when I tried to compile the code, the async interface related code cannot pass compilation. Because hiredis cannot compile with -Wconversion. See this for detail.
I'll merge your PR, and also modify some async interface related code to make it compile with -Wshadow, -Wcast-qual and -Wconversion. However, I have to remove these compiler options unless hiredis adds these options in its Makefile. Because I've no idea whether hiredis might add some code in the future, violating these options, and make redis-plus-plus fail to compile. Hope you understand. And you can try to create a PR for hiredis to add these options in its Makefile.
Regards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a few warning options to the build:
-Wshadow -Wconversion -Wcast-qual
-Wsign-conversion can also be added if the below pull request is approved:
redis/hiredis#1064
Signed-off-by: Ted Lyngmo [email protected]