Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain collapsed state of Ringdowns list when switching tabs in ER view #274

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Maintain collapsed state of Ringdowns list when switching tabs in ER view #274

wants to merge 10 commits into from

Conversation

kretzbryan
Copy link
Collaborator

No description provided.

@fwextensions
Copy link
Collaborator

Thanks for this, @kretzbryan. I'm not sure writing the state to localStorage is the best approach, as we'd be leaving behind the title of each ringdown in the browser, and there's no guarantee they'd be unique. Seems like the app itself would need to maintain the state. Or the tab could just be hidden, instead of torn down, so the expanded state would be maintained in the DOM.

@kretzbryan
Copy link
Collaborator Author

I'm not sure if we're going to have other ui features related to the ringdown sections, so I structured the state so we can add more values to each section. If you think all we're expecting is to expand them, then I can simplify the state a little more.

@fwextensions fwextensions linked an issue Mar 6, 2023 that may be closed by this pull request
ER: collapsing a section of the Ringdown list doesn't persist across a tab change #240
Open
@fwextensions fwextensions changed the title Bkretz/bug/240 Maintain collapsed state of Ringdowns list when switching tabs in ER view Mar 6, 2023
fwextensions
fwextensions reviewed Mar 6, 2023
View reviewed changes
client/src/Context.js Outdated Show resolved Hide resolved
fwextensions
fwextensions reviewed Mar 6, 2023
View reviewed changes
client/src/ER/ER.js Outdated Show resolved Hide resolved
@ddrosario ddrosario mentioned this pull request Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwextensions fwextensions fwextensions left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ER: collapsing a section of the Ringdown list doesn't persist across a tab change
2 participants
@kretzbryan @fwextensions