Fix future-incompat report
#828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @EricFecteau for the PR! The old tiberius is kept due to this issue: #762 (downgraded in this commit: 37dd8ed). But I still don't know the root cause for this though. |
|
Ah yeah, that makes sense! Will close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building,
connector-xprovides afuture-incompatwarning (see here: https://github.com/sfu-db/connector-x/actions/runs/16383175035/job/46298417726?pr=827#step:12:534) for the crateconnection-string v0.1.13. This was a dependency of the version oftiberiusbeing used byconnector-x. I updatedtiberiusto the latest version, and updated the related cratesbb8andbb8-tiberius. This also solved the incompatibility ofuuidversion 1 (removing theuuid_oldcrate.Warning: I don't have an MS SQL server to verify that this did not cause any issues. Uncertain what to do about that.