Do not add -mfpu and -mfloat-abi arguments if build target is Apple. #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppleClang does not support those arguments anymore: ``` c++: error: unsupported option '-mfpu=' for target 'arm64-apple-darwin23.6.0' c++: error: unsupported option '-mfloat-abi=' for target 'arm64-apple-darwin23.6.0' cc: error: unsupported option '-mfpu=' for target 'arm64-apple-darwin23.6.0' cc: error: unsupported option '-mfloat-abi=' for target 'arm64-apple-darwin23.6.0' ``` seealso: https://stackoverflow.com/questions/29851128/gcc-arm64-aarch64-unrecognized-command-line-option-mfpu-neon
PythonBlue
added a commit
to PythonBlue/sfizz
that referenced
this pull request
Jan 1, 2025
Fix for compiling on Apple machines in light of pull request sfztools#1307 in the main repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes macOS arm64 builds for me (which also seems failing on GitHub Actions builds here).
AppleClang does not support those arguments anymore:
seealso: https://stackoverflow.com/questions/29851128/gcc-arm64-aarch64-unrecognized-command-line-option-mfpu-neon