Fixes for build errors when using CMake -G Xcode
#1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The atomic_queue clang build fix patches are also in there... just thought they should be mentioned too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac, CMake's Makefile generator seems to build everything with dual-architecture. However, the Xcode generator seems to build the architectures individually and then stick them together afterwards.
Since
PROJECT_SYSTEM_PROCESSORwill contain both architectures, this always adds x86/x86_64 flags (e.g.-msse2) which cause an error when compiling the Apple Silicon part.This PR uses Clang's
-Xarch_...filters to say those flags are only relevant for certain architectures.