Support numerical and * (any) array subscripts for INFO fields #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
@jeromekelleher are you happy for this to go in? |
|
Would be good to get a bit more test coverage if possible. What happens on out-of-bounds and other errors (is it the same as bcftools)? Check some other fields, with different types? Does this also apply to sample-dimensioned fields? I find there's usually something weird lurking when you try some odd corner cases with bcftools and you just have to poke them out. |
|
It looks like bcftools is lenient with indexes - so there's more work to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #167
There are more types of indexing that can be added later