Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vulkan validation #267

Merged
merged 10 commits into from
Mar 19, 2025
Merged

Fix vulkan validation #267

merged 10 commits into from
Mar 19, 2025

Conversation

westlicht
Copy link
Collaborator

  • disable debug printf unless specifically enabled using the new VulkanDeviceExtendedDesc (this gets rid of the annoying validation message)
  • fix semaphore wait stages in submit
  • fix surface <-> submit synchronization
  • fix initial swapchain image barrier

ccummingsNV
ccummingsNV approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ccummingsNV ccummingsNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments worth you double checking, but otherwise looks good.

@skallweitNV skallweitNV merged commit e3e91ef into main Mar 19, 2025
17 checks passed
@skallweitNV skallweitNV deleted the fix-vulkan-validation branch March 19, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skallweitNV skallweitNV skallweitNV left review comments

@ccummingsNV ccummingsNV ccummingsNV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westlicht @skallweitNV @ccummingsNV