Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface improvements #268

Merged
merged 5 commits into from
Mar 19, 2025
Merged

Surface improvements #268

merged 5 commits into from
Mar 19, 2025

Conversation

westlicht
Copy link
Collaborator

  • rename getCurrentTexture to acquireNextImage which is what that functions does
  • allow presenting an image that has not been rendered to
  • add validation for the acquireNextImage -> present dependency

ccummingsNV
ccummingsNV approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ccummingsNV ccummingsNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I ignored changes that were from the previous unmerged PR)

@skallweitNV skallweitNV force-pushed the surface-improvements branch from 431c41c to 8b497fb Compare March 19, 2025 09:57
@skallweitNV skallweitNV merged commit e8cf2a5 into main Mar 19, 2025
17 checks passed
@skallweitNV skallweitNV deleted the surface-improvements branch March 19, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skallweitNV skallweitNV skallweitNV left review comments

@ccummingsNV ccummingsNV ccummingsNV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@westlicht @skallweitNV @ccummingsNV