Enable GCP runner for RHI workflow #370
Conversation
aasgaonkar
commented
May 30, 2025
aasgaonkar
commented
- enable gcp for msvc debug build config
- ignore raytracing failure for GCP runs
|
|
aasgaonkar
force-pushed
the
feature/enable_gcp
branch
10 times, most recently
from
76332e0 to
dc9b78b
Compare
| @@ -29,14 +29,14 @@ jobs: | |||
| # Builds running on self-hosted runners (build + tests) | |||
| - { os: windows, platform: "x86_64", compiler: clang, preset: clang, config: "Debug", flags: "unit-test,coverage", runs-on: { group: nvrgfx, labels: [Windows, X64] } } | |||
| - { os: windows, platform: "x86_64", compiler: msvc, preset: default, config: "Release", flags: "unit-test", runs-on: { group: nvrgfx, labels: [Windows, X64] } } | |||
| - { os: windows, platform: "x86_64", compiler: msvc, preset: default, config: "Debug", flags: "unit-test", runs-on: { group: gcp, labels: [Windows, X64] } } | |||
There was a problem hiding this comment.
I think we prefer running on our machines for the time being. So if we want to additionally run on GCP machines, we should probably do that in a separate workflow.
There was a problem hiding this comment.
this is taking the build only windows workflow and using GCP runner, so it should be a parallel workflow to existing test coverage.
There was a problem hiding this comment.
That's true. I was under the impression that we are limited with GCP resources, so I'd rather see these resources spent on testing slang-rhi with latest slang on all platforms/build configs in the slang CI. We have good coverage already with the build machines here. Also we could enable release build testing, should be OK with the amount of build machines we have available now. So, I see this GCP workflow more like a way to test that slang-rhi tests run on GCP. So this could be a dispatch only workflow even.
There was a problem hiding this comment.
@dryu-nv Thoughts on this? Adding GCP support will add strain on the resources. we have 4 windows runners currently.
There was a problem hiding this comment.
we spoke about this in the slang scrum meeting - let's merge this and enable GCP platform testing. if there are issues, we can add more windows runeers and make sure there is enough capacity for all.
aasgaonkar
force-pushed
the
feature/enable_gcp
branch
4 times, most recently
from
ac32440 to
60c29a0
Compare
- enable build + test workflow for windows/msvc/debug - remove build only workflow for same config - ignore raytracing failure for GCP runs
aasgaonkar
force-pushed
the
feature/enable_gcp
branch
from
60c29a0 to
4c3b894
Compare
|
@jkwak-work can you help merge the PR? |
This reverts commit ba0f576.
