Skip to content

Fix slang-rhi build for slang #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Conversation

szihs
Copy link
Contributor

@szihs szihs commented Jun 2, 2025

Also fix build issue when building as part of slang

Copy link
Collaborator

@skallweitNV skallweitNV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the [raypayload] attribute and PAQs are already in ToT.

@szihs szihs force-pushed the haaggarwal/paq_robustness branch from 50aa51f to ac5b408 Compare June 2, 2025 13:30
…LD_EXAMPLES on building slang

```
CMake Error at external/slang-rhi/CMakeLists.txt:691 (add_library):
add_library cannot create target "stb" because another target with the
same name already exists.  The existing target is an interface library
created in source directory
```
@skallweitNV skallweitNV force-pushed the haaggarwal/paq_robustness branch from ac5b408 to 8db24cd Compare June 3, 2025 09:04
@skallweitNV skallweitNV changed the title Fix PAQ robustness. Fix slang-rhi build for slang Jun 3, 2025
@skallweitNV skallweitNV merged commit 0a11cfc into main Jun 3, 2025
18 checks passed
@skallweitNV skallweitNV deleted the haaggarwal/paq_robustness branch June 3, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants