[WGSL] [WASM] Add reflection endpoints + Fix bit manipulation operations #5499
+170
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saipraveenb25
commented
Nov 5, 2024
saipraveenb25
commented
- Add necessary layout reflection endpoints to Slang API's WASM bindings.
- Emit parenthesis around bit-shift, bit-xor and bit-or operations to avoid WGSL compiler complaining about precendence issues.
csyonghe
previously approved these changes
Nov 5, 2024
| @@ -386,6 +386,47 @@ HashedString* ComponentType::loadStrings() | |||
| return hashedStrings; | |||
| } | |||
|
|
|||
| ProgramLayout* ComponentType::getLayout(unsigned int targetIndex) | |||
There was a problem hiding this comment.
This is going to making really hard in javascript to ensure all these reflection objects are explicitly delete()'d when they are no longer in use.
We should instead just return a raw pointer to the layout without allocating a fresh object on the heap, and use allow_raw_pointers in emscripten bind, to free the javascript side from the responsibility of manually calling delete().
There was a problem hiding this comment.
Okay, let me see if I can change up the wasm bindings
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
|
@saipraveenb25 this PR is still not ready to merge, can you fix the formatting? |
|
@saipraveenb25 do you have plans to change the pointer ownership model in the wasm binding here? |
csyonghe
previously approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.