Transfer offset decorations when legalizing laid-out structs #5525
+32
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Struct legalization removing fields not representable in memory should transfer offset decorations in case the struct has already had offsets calculated. Closes shader-slang#5264.
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#5525
csyonghe
reviewed
Nov 8, 2024
| // In case the original struct had offsets calculated, transfer those as well. | ||
| // The original offsets should still be valid, since we only skip fields of types | ||
| // that aren't representable in memory. | ||
| originalField->transferChildrenOfTypeTo<IROffsetDecoration>(newField); |
There was a problem hiding this comment.
Just transfer all decorations over.
csyonghe
reviewed
Nov 8, 2024
| @@ -780,8 +793,20 @@ struct IRInst | |||
| void removeOperand(Index index); | |||
|
|
|||
| /// Transfer any decorations of this instruction to the `target` instruction. | |||
| // TODO: rewrite as transferDecorationsTo(target) -> | |||
csyonghe
reviewed
Nov 8, 2024
| @@ -593,6 +593,19 @@ struct IRInst | |||
| IRDecoration* getLastDecoration(); | |||
| IRInstList<IRDecoration> getDecorations(); | |||
|
|
|||
| // Step to the next child of a certain type, T | |||
There was a problem hiding this comment.
Don’t need this, just copy all decorations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struct legalization removing fields not representable in memory should transfer offset decorations in case the struct has already had offsets calculated.
Closes #5264.