src/login_nopam.c: Rely on the system's MAXHOSTNAMELEN #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
maxhostnamelen
branch
3 times, most recently
from
c2f9ee4
to
4065295
Compare
The reason for that code seems to be some ancient AIX version that defined a value that was too small (32). We don't support such systems. In the link below, I found the following comment and code: /* * Some AIX versions advertise a too small MAXHOSTNAMELEN value (32). * Result: long hostnames would be truncated, and connections would be * dropped because of host name verification failures. Adrian van Bloois * ([email protected]) figured out what was the problem. */ #if (MAXHOSTNAMELEN < 64) #undef MAXHOSTNAMELEN #endif /* In case not defined in <sys/param.h>. */ #ifndef MAXHOSTNAMELEN #define MAXHOSTNAMELEN 256 /* storage for host name */ #endif Today's systems seem to be much better regarding this macro. Rely on them. Link: <https://sources.debian.org/src/tcp-wrappers/7.6.q-33/workarounds.c/?hl=36#L36> Signed-off-by: Alejandro Colomar <[email protected]>
alejandro-colomar
force-pushed
the
maxhostnamelen
branch
from
4065295
to
c0cb965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for that code seems to be some ancient AIX versions that defined a value that was too small (32). We don't support such systems. In the link below, I found the following comment and code:
Today's systems seem to be much better regarding this macro. Rely on them.
Link: https://sources.debian.org/src/tcp-wrappers/7.6.q-33/workarounds.c/?hl=36#L36
Revisions:
v1b
v2