ls

[alejandro-colomar]

I've managed to remove one of the static, but most of them seem necessary, since these shadow APIs are either libc APIs or similar to libc APIs, and they're specified as using static memory.

I've also done a lot of simplification and de-duplication work in surrounding code, especially in code transforming CSVs to lists.

---

Revisions:

v1b

• Rebase

$ git rd 
 1:  bc196a4c =  1:  e030f9f9 lib/shadow/group/sgetgrent.c: Move free(3) call outside of helper
 2:  03fd5229 =  2:  922cd79c lib/shadow/gshadow/sgetsgent.c: Don't exit from library code
 3:  da4f193d =  3:  6087810b lib/, src/: Use more readable syntax for empty loops
 4:  969c53f6 =  4:  2b9b392d lib/: Deduplicate code
 5:  6bd67e17 =  5:  5a34d66d lib/list.c: comma_to_list(): Allow a trailing comma
 6:  140d5c09 =  6:  7ff2273b lib/list.c: comma_to_list(): Use xastrsep2ls() instead of its pattern
 7:  c1cf0676 =  7:  d6c5e912 lib/shadow/group/sgetgrent.c: Remove redundant code
 8:  09918ba6 =  8:  156085ca lib/list.c: comma_to_list(): Use build_list() instead of its pattern
 9:  06062942 =  9:  f1ee9cd3 lib/: Rename build_list() => acsv2ls()
10:  f0e13f5b = 10:  4f27d718 lib/, src/: Move list.c prototypes to new file list.h

v1c

• Rebase

$ git rd 
 1:  e030f9f9 =  1:  fdba8427 lib/shadow/group/sgetgrent.c: Move free(3) call outside of helper
 2:  922cd79c =  2:  721a5846 lib/shadow/gshadow/sgetsgent.c: Don't exit from library code
 3:  6087810b =  3:  baac1e9f lib/, src/: Use more readable syntax for empty loops
 4:  2b9b392d =  4:  1b10b043 lib/: Deduplicate code
 5:  5a34d66d =  5:  56803058 lib/list.c: comma_to_list(): Allow a trailing comma
 6:  7ff2273b =  6:  2ad1c605 lib/list.c: comma_to_list(): Use xastrsep2ls() instead of its pattern
 7:  d6c5e912 =  7:  070df553 lib/shadow/group/sgetgrent.c: Remove redundant code
 8:  156085ca =  8:  5ae417e6 lib/list.c: comma_to_list(): Use build_list() instead of its pattern
 9:  f1ee9cd3 =  9:  f3e1a203 lib/: Rename build_list() => acsv2ls()
10:  4f27d718 = 10:  5ec6addd lib/, src/: Move list.c prototypes to new file list.h

v1d

• Rebase

$ git rd 
 1:  fdba8427c =  1:  3ed5c07dd lib/shadow/group/sgetgrent.c: Move free(3) call outside of helper
 2:  721a5846d !  2:  a5f67fa47 lib/shadow/gshadow/sgetsgent.c: Don't exit from library code
    @@ Commit message
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/shadow/gshadow/sgetsgent.c ##
    -@@
    - 
    - #include "shadow/gshadow/sgrp.h"
    - #include "string/strcmp/streq.h"
    -+#include "string/strtok/astrsep2ls.h"
    - #include "string/strtok/stpsep.h"
    - #include "string/strtok/strsep2arr.h"
    --#include "string/strtok/xastrsep2ls.h"
    - 
    - 
    - #if defined(SHADOWGRP) && !__has_include(<gshadow.h>)
     @@ lib/shadow/gshadow/sgetsgent.c: sgetsgent(const char *s)
        sgroup.sg_adm = build_list(fields[2]);
        sgroup.sg_mem = build_list(fields[3]);
 3:  baac1e9ff =  3:  b148e9e58 lib/, src/: Use more readable syntax for empty loops
 4:  1b10b0432 !  4:  35f0cf989 lib/: Deduplicate code
    @@ lib/list.c
     @@
      #include "string/strchr/strchrcnt.h"
      #include "string/strcmp/streq.h"
    - #include "string/strdup/xstrdup.h"
    + #include "string/strdup/strdup.h"
     +#include "string/strtok/astrsep2ls.h"
      #include "string/strtok/strsep2ls.h"
      
 5:  568030588 =  5:  aecafd272 lib/list.c: comma_to_list(): Allow a trailing comma
 6:  2ad1c6058 !  6:  dbaa72cad lib/list.c: comma_to_list(): Use xastrsep2ls() instead of its pattern
    @@ Commit message
     
      ## lib/list.c ##
     @@
    - #include "alloc/x/xmalloc.h"
    + #include "alloc/malloc.h"
      #include "prototypes.h"
      #include "defines.h"
     -#include "string/strchr/strchrcnt.h"
      #include "string/strcmp/streq.h"
    - #include "string/strdup/xstrdup.h"
    + #include "string/strdup/strdup.h"
      #include "string/strtok/astrsep2ls.h"
     -#include "string/strtok/strsep2ls.h"
     +#include "string/strtok/xastrsep2ls.h"
 7:  070df5533 =  7:  904bbf690 lib/shadow/group/sgetgrent.c: Remove redundant code
 8:  5ae417e6d !  8:  0e6a1845b lib/list.c: comma_to_list(): Use build_list() instead of its pattern
    @@ lib/list.c
      
     @@
      #include "string/strcmp/streq.h"
    - #include "string/strdup/xstrdup.h"
    + #include "string/strdup/strdup.h"
      #include "string/strtok/astrsep2ls.h"
     -#include "string/strtok/xastrsep2ls.h"
      
 9:  f3e1a203f =  9:  4e16128ca lib/: Rename build_list() => acsv2ls()
10:  5ec6adddb ! 10:  df842fb78 lib/, src/: Move list.c prototypes to new file list.h
    @@ lib/list.c
      
      #include <assert.h>
      
    - #include "alloc/x/xmalloc.h"
    + #include "alloc/malloc.h"
     -#include "prototypes.h"
      #include "defines.h"
      #include "string/strcmp/streq.h"
    - #include "string/strdup/xstrdup.h"
    + #include "string/strdup/strdup.h"
     
      ## lib/list.h (new) ##
     @@
    @@ src/groupadd.c
     
      ## src/groupmems.c ##
     @@
    - #include "alloc/x/xmalloc.h"
    + #include "alloc/malloc.h"
      #include "defines.h"
      #include "groupio.h"
     +#include "list.h"