Add and use memdup(), MEMDUP(), instead of its pattern #1296

alejandro-colomar · 2025-07-16T15:47:01Z

Revisions:

v2

Remove n parameter in MEMDUP(). I think we won't need it, as it will likely be 1 everywhere we might want to duplicate memory. The use of this API seems to be duplicating a pointer to structure that uses static storage in non-reentrant functions.
malloc(3) doesn't need the ?: 1 trick. That's just for realloc(3).

$ git rd 
1:  67923ed0 ! 1:  eaf1e24f lib/string/strdup/: memdup(), MEMDUP(): Add APIs
    @@ lib/string/strdup/memdup.h (new)
     +#include "attr.h"
     +
     +
    -+#define MEMDUP(p, n, T)  _Generic(p, T *: (T *) memdup(p, n * sizeof(T)))
    ++#define MEMDUP(p, T)  _Generic(p, T *: (T *) memdup(p, sizeof(T)))
     +
     +
     +ATTR_MALLOC(free)
    @@ lib/string/strdup/memdup.h (new)
     +{
     +  void  *new;
     +
    -+  new = malloc(size ?: 1);
    ++  new = malloc(size);
     +  if (new == NULL)
     +          return NULL;
     +
2:  7bdb4e11 = 2:  62e91ee4 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
3:  d9925423 ! 3:  5239d2bb lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ lib/utmp.c: get_current_utmp(void)
     -                  memcpy(ret, ut, sizeof (*ret));
     -  }
     +  if (NULL != ut)
    -+          ut = MEMDUP(ut, 1, struct utmpx);
    ++          ut = MEMDUP(ut, struct utmpx);
      
        endutxent();

v2b

Rebase

$ git rd 
1:  eaf1e24f = 1:  894bbbf8 lib/string/strdup/: memdup(), MEMDUP(): Add APIs
2:  62e91ee4 ! 2:  3775e2a3 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
    @@ lib/utmp.c
      #include "alloc/x/xcalloc.h"
     -#include "alloc/x/xmalloc.h"
      #include "sizeof.h"
    + #include "string/strchr/strnul.h"
      #include "string/strcmp/streq.h"
    - #include "string/strcmp/strprefix.h"
     @@ lib/utmp.c: get_current_utmp(void)
        }
      
3:  5239d2bb ! 3:  e6e4c808 lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ lib/utmp.c
     -#include "alloc/malloc.h"
      #include "alloc/x/xcalloc.h"
      #include "sizeof.h"
    - #include "string/strcmp/streq.h"
    + #include "string/strchr/strnul.h"
    +@@
      #include "string/strcmp/strprefix.h"
      #include "string/strcpy/strncpy.h"
      #include "string/strcpy/strtcpy.h"

v3

Rebase

$ git range-diff 894bbbf8add6^..gh/memdup shadow/master..memdup 
1:  894bbbf8 = 1:  f8276a62 lib/string/strdup/: memdup(), MEMDUP(): Add APIs
2:  3775e2a3 ! 2:  fb5f9fc9 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
    @@ lib/utmp.c
      #include "sizeof.h"
      #include "string/strchr/strnul.h"
      #include "string/strcmp/streq.h"
    -@@ lib/utmp.c: get_current_utmp(void)
    -   }
    - 
    +@@ lib/utmp.c: get_current_utmp(pid_t main_pid)
        if (NULL != ut) {
    --          ret = XMALLOC(1, struct utmpx);
    --          memcpy (ret, ut, sizeof (*ret));
    -+          ret = MALLOC(1, struct utmpx);
    -+          if (ret != NULL)
    -+                  memcpy(ret, ut, sizeof (*ret));
    +           struct utmpx  *ut_copy;
    + 
    +-          ut_copy = XMALLOC(1, struct utmpx);
    +-          memcpy(ut_copy, ut, sizeof(*ut));
    ++          ut_copy = MALLOC(1, struct utmpx);
    ++          if (ut_copy != NULL)
    ++                  memcpy(ut_copy, ut, sizeof(*ut));
    +           ut = ut_copy;
        }
      
    -   endutxent();
3:  e6e4c808 ! 3:  903035d4 lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ lib/utmp.c
      #include "string/strdup/xstrdup.h"
      #include "string/strdup/xstrndup.h"
      
    -@@ lib/utmp.c: static /*@null@*/ /*@only@*/struct utmpx *
    - get_current_utmp(void)
    - {
    -   struct utmpx  *ut;
    --  struct utmpx  *ret = NULL;
    - 
    -   setutxent();
    - 
    -@@ lib/utmp.c: get_current_utmp(void)
    +@@ lib/utmp.c: get_current_utmp(pid_t main_pid)
                }
        }
      
     -  if (NULL != ut) {
    --          ret = MALLOC(1, struct utmpx);
    --          if (ret != NULL)
    --                  memcpy(ret, ut, sizeof (*ret));
    +-          struct utmpx  *ut_copy;
    +-
    +-          ut_copy = MALLOC(1, struct utmpx);
    +-          if (ut_copy != NULL)
    +-                  memcpy(ut_copy, ut, sizeof(*ut));
    +-          ut = ut_copy;
     -  }
     +  if (NULL != ut)
     +          ut = MEMDUP(ut, struct utmpx);
      
        endutxent();
      
    --  return ret;
    -+  return ut;
    - }
    - 
    -

v4

Rebase

$ git rd 
1:  f8276a62 = 1:  af04fb6d lib/string/strdup/: memdup(), MEMDUP(): Add APIs
2:  fb5f9fc9 ! 2:  9fe1fa3a lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
    @@ lib/utmp.c
     +#include "alloc/malloc.h"
      #include "alloc/x/xcalloc.h"
     -#include "alloc/x/xmalloc.h"
    + #include "attr.h"
      #include "sizeof.h"
      #include "string/strchr/strnul.h"
    - #include "string/strcmp/streq.h"
     @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
        if (NULL != ut) {
                struct utmpx  *ut_copy;
3:  903035d4 ! 3:  ab7bb521 lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ lib/utmp.c
      
     -#include "alloc/malloc.h"
      #include "alloc/x/xcalloc.h"
    + #include "attr.h"
      #include "sizeof.h"
    - #include "string/strchr/strnul.h"
     @@
      #include "string/strcmp/strprefix.h"
      #include "string/strcpy/strncpy.h"
    @@ lib/utmp.c
      #include "string/strdup/xstrndup.h"
      
     @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
    -           }
    -   }
    +   if (NULL == ut)
    +           ut = ut_by_pid ?: ut_by_line;
      
     -  if (NULL != ut) {
     -          struct utmpx  *ut_copy;
    @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
     +  if (NULL != ut)
     +          ut = MEMDUP(ut, struct utmpx);
      
    -   endutxent();
    - 
    +   free(ut_by_line);
    +   free(ut_by_pid);

v4b

Rebase

$ git rd 
1:  af04fb6d = 1:  a1ebec8c lib/string/strdup/: memdup(), MEMDUP(): Add APIs
2:  9fe1fa3a = 2:  5fc012b4 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
3:  ab7bb521 = 3:  06c665ad lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern

v4c

Rebase

$ git rd 
1:  a1ebec8c = 1:  895034b7 lib/string/strdup/: memdup(), MEMDUP(): Add APIs
2:  5fc012b4 = 2:  19e196c8 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
3:  06c665ad = 3:  1b732dbc lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern

v4d

Rebase

$ git rd 
1:  895034b7 ! 1:  56500038 lib/string/strdup/: memdup(), MEMDUP(): Add APIs
    @@ lib/Makefile.am: libshadow_la_SOURCES = \
        string/strcpy/strtcpy.h \
     +  string/strdup/memdup.c \
     +  string/strdup/memdup.h \
    +   string/strdup/strdup.c \
    +   string/strdup/strdup.h \
        string/strdup/strndupa.c \
    -   string/strdup/strndupa.h \
    -   string/strdup/xstrdup.c \
     
      ## lib/string/strdup/memdup.c (new) ##
     @@
2:  19e196c8 ! 2:  33cba471 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
    @@ Commit message
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/utmp.c ##
    -@@
    - #include <string.h>
    - #include <fcntl.h>
    - 
    -+#include "alloc/malloc.h"
    - #include "alloc/x/xcalloc.h"
    --#include "alloc/x/xmalloc.h"
    - #include "attr.h"
    - #include "sizeof.h"
    - #include "string/strchr/strnul.h"
     @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
        if (NULL != ut) {
                struct utmpx  *ut_copy;
3:  1b732dbc ! 3:  d7eb6b89 lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ Commit message
     
      ## lib/utmp.c ##
     @@
    - #include <string.h>
      #include <fcntl.h>
      
    + #include "alloc/calloc.h"
     -#include "alloc/malloc.h"
    - #include "alloc/x/xcalloc.h"
      #include "attr.h"
      #include "sizeof.h"
    + #include "string/strchr/strnul.h"
     @@
      #include "string/strcmp/strprefix.h"
      #include "string/strcpy/strncpy.h"
      #include "string/strcpy/strtcpy.h"
     +#include "string/strdup/memdup.h"
    - #include "string/strdup/xstrdup.h"
    - #include "string/strdup/xstrndup.h"
    + #include "string/strdup/strdup.h"
    + #include "string/strdup/strndup.h"
      
     @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
        if (NULL == ut)

v5

Add missing include.
Rename s/MEMDUP/memdup_a/.

$ git rd 
1:  565000388 ! 1:  c70395f34 lib/string/strdup/: memdup(), MEMDUP(): Add APIs
    @@ Metadata
     Author: Alejandro Colomar <[email protected]>
     
      ## Commit message ##
    -    lib/string/strdup/: memdup(), MEMDUP(): Add APIs
    +    lib/string/strdup/: memdup[_a](): Add APIs
     
         Signed-off-by: Alejandro Colomar <[email protected]>
     
    @@ lib/string/strdup/memdup.h (new)
     +#include "attr.h"
     +
     +
    -+#define MEMDUP(p, T)  _Generic(p, T *: (T *) memdup(p, sizeof(T)))
    ++// memdup_a - memory duplicate array
    ++#define memdup_a(p, T)  _Generic(p, T *: (T *) memdup(p, sizeof(T)))
     +
     +
     +ATTR_MALLOC(free)
     +inline void *memdup(const void *p, size_t size);
     +
     +
    -+// memory duplicate
    ++// memdup - memory duplicate
     +inline void *
     +memdup(const void *p, size_t size)
     +{
2:  33cba4713 = 2:  e3d1bec95 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
3:  d7eb6b89e ! 3:  5aff45d10 lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ Metadata
     Author: Alejandro Colomar <[email protected]>
     
      ## Commit message ##
    -    lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    +    lib/utmp.c: get_current_utmp(): Use memdup_a() instead of its pattern
     
         Cc: "Evgeny Grin (Karlson2k)" <[email protected]>
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/utmp.c ##
    -@@
    - #include <fcntl.h>
    - 
    - #include "alloc/calloc.h"
    --#include "alloc/malloc.h"
    - #include "attr.h"
    - #include "sizeof.h"
    - #include "string/strchr/strnul.h"
     @@
      #include "string/strcmp/strprefix.h"
      #include "string/strcpy/strncpy.h"
    @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
     -          ut = ut_copy;
     -  }
     +  if (NULL != ut)
    -+          ut = MEMDUP(ut, struct utmpx);
    ++          ut = memdup_a(ut, struct utmpx);
      
        free(ut_by_line);
        free(ut_by_pid);

v6

Revert v5, which was totally bogus.

$ git rd 
1:  c70395f34 ! 1:  565000388 lib/string/strdup/: memdup[_a](): Add APIs
    @@ Metadata
     Author: Alejandro Colomar <[email protected]>
     
      ## Commit message ##
    -    lib/string/strdup/: memdup[_a](): Add APIs
    +    lib/string/strdup/: memdup(), MEMDUP(): Add APIs
     
         Signed-off-by: Alejandro Colomar <[email protected]>
     
    @@ lib/string/strdup/memdup.h (new)
     +#include "attr.h"
     +
     +
    -+// memdup_a - memory duplicate array
    -+#define memdup_a(p, T)  _Generic(p, T *: (T *) memdup(p, sizeof(T)))
    ++#define MEMDUP(p, T)  _Generic(p, T *: (T *) memdup(p, sizeof(T)))
     +
     +
     +ATTR_MALLOC(free)
     +inline void *memdup(const void *p, size_t size);
     +
     +
    -+// memdup - memory duplicate
    ++// memory duplicate
     +inline void *
     +memdup(const void *p, size_t size)
     +{
2:  e3d1bec95 = 2:  33cba4713 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
3:  5aff45d10 ! 3:  d7eb6b89e lib/utmp.c: get_current_utmp(): Use memdup_a() instead of its pattern
    @@ Metadata
     Author: Alejandro Colomar <[email protected]>
     
      ## Commit message ##
    -    lib/utmp.c: get_current_utmp(): Use memdup_a() instead of its pattern
    +    lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
     
         Cc: "Evgeny Grin (Karlson2k)" <[email protected]>
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/utmp.c ##
    +@@
    + #include <fcntl.h>
    + 
    + #include "alloc/calloc.h"
    +-#include "alloc/malloc.h"
    + #include "attr.h"
    + #include "sizeof.h"
    + #include "string/strchr/strnul.h"
     @@
      #include "string/strcmp/strprefix.h"
      #include "string/strcpy/strncpy.h"
    @@ lib/utmp.c: get_current_utmp(pid_t main_pid)
     -          ut = ut_copy;
     -  }
     +  if (NULL != ut)
    -+          ut = memdup_a(ut, struct utmpx);
    ++          ut = MEMDUP(ut, struct utmpx);
      
        free(ut_by_line);
        free(ut_by_pid);

v6b

Rebase

$ git rd 
1:  565000388 ! 1:  3ab394e09 lib/string/strdup/: memdup(), MEMDUP(): Add APIs
    @@ lib/string/strdup/memdup.h (new)
     +inline void *memdup(const void *p, size_t size);
     +
     +
    -+// memory duplicate
    ++// memdup - memory duplicate
     +inline void *
     +memdup(const void *p, size_t size)
     +{
2:  33cba4713 = 2:  d85dc7819 lib/utmp.c: get_current_utmp(): Don't exit(3) from library code
3:  d7eb6b89e ! 3:  a3f05ac24 lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern
    @@ Commit message
         Signed-off-by: Alejandro Colomar <[email protected]>
     
      ## lib/utmp.c ##
    -@@
    - #include <fcntl.h>
    - 
    - #include "alloc/calloc.h"
    --#include "alloc/malloc.h"
    - #include "attr.h"
    - #include "sizeof.h"
    - #include "string/strchr/strnul.h"
     @@
      #include "string/strcmp/strprefix.h"
      #include "string/strcpy/strncpy.h"

Karlson2k · 2025-07-18T10:04:57Z

I still recommend adding attribute malloc (in form without destructor). When used without -fno-strict-aliasing (like this project) it improves optimisations.

Karlson2k · 2025-07-18T10:10:55Z

See https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-malloc-function-attribute

Attribute malloc indicates that a function is malloc-like, i.e., that the pointer P returned by the function cannot alias any other pointer valid when the function returns, and moreover no pointers to valid objects occur in any storage addressed by P. In addition, GCC predicts that a function with the attribute returns non-null in most cases.

Independently, the form of the attribute with one or two arguments associates deallocator as a suitable deallocation function for pointers returned from the malloc-like function. ptr-index denotes the positional argument to which when the pointer is passed in calls to deallocator has the effect of deallocating it.

For example, besides stating that the functions return pointers that do not alias any others, the following declarations make fclose a suitable deallocator for pointers returned from all functions except popen, and pclose as the only suitable deallocator for pointers returned from popen. The deallocator functions must be declared before they can be referenced in the attribute.
int fclose (FILE*);
int pclose (FILE*);

__attribute__ ((malloc, malloc (fclose, 1)))
  FILE* fdopen (int, const char*);
__attribute__ ((malloc, malloc (fclose, 1)))
  FILE* fopen (const char*, const char*);
__attribute__ ((malloc, malloc (fclose, 1)))
  FILE* fmemopen(void *, size_t, const char *);
__attribute__ ((malloc, malloc (pclose, 1)))
  FILE* popen (const char*, const char*);
__attribute__ ((malloc, malloc (fclose, 1)))
  FILE* tmpfile (void);

alejandro-colomar · 2025-07-18T10:57:12Z

I still recommend adding attribute malloc (in form without destructor). When used without -fno-strict-aliasing (like this project) it improves optimisations.

I think by having this function declared inline the compiler should be able to realize about any possible optimizations, since it transparently sees the malloc(3) call.

I don't like using attributes for telling the compiler that it can optimize. That's error-prone. I prefer allowing it to see more of the code, so it can reason by itself.

Karlson2k · 2025-07-18T11:01:53Z

I think by having this function declared inline the compiler should be able to realize about any possible optimizations, since it transparently sees the malloc(3) call.

Then you do not need current ATTR_MALLOC(free) as compiler may see malloc() call.
It looks inconsistent that function must have two attributes, but uses only one of them.

alejandro-colomar · 2025-07-18T11:06:32Z

I think by having this function declared inline the compiler should be able to realize about any possible optimizations, since it transparently sees the malloc(3) call.

Then you do not need current ATTR_MALLOC(free) as compiler may see malloc() call. It looks inconsistent that function must have two attributes, but uses only one of them.

The ATTR_MALLOC(free) attribute is not for optimization, but for safety. It allows the compiler to warn when we forget to free(3). There, redundancy increases safety.

lib/string/strdup/memdup.h

Signed-off-by: Alejandro Colomar <[email protected]>

This function already returned NULL on some errors. It didn't make any sense to exit(3) on allocation failure. Instead, just return NULL. Signed-off-by: Alejandro Colomar <[email protected]>

Cc: "Evgeny Grin (Karlson2k)" <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>

alejandro-colomar requested a review from hallyn July 16, 2025 15:47

alejandro-colomar changed the title ~~Add and use memdup(), MEMDUP()~~ Add and use memdup(), MEMDUP(), instead of its pattern Jul 16, 2025

alejandro-colomar force-pushed the memdup branch from f906dbd to f09d8ec Compare July 16, 2025 15:52

alejandro-colomar marked this pull request as ready for review July 16, 2025 16:22

alejandro-colomar force-pushed the memdup branch from f09d8ec to d992542 Compare July 16, 2025 20:36

alejandro-colomar mentioned this pull request Jul 18, 2025

Correct finding UTMP entry #1292

Merged

alejandro-colomar force-pushed the memdup branch from d992542 to 5239d2b Compare July 18, 2025 09:57

alejandro-colomar force-pushed the memdup branch 2 times, most recently from e6e4c80 to 903035d Compare July 18, 2025 20:12

Karlson2k approved these changes Jul 19, 2025

View reviewed changes

alejandro-colomar mentioned this pull request Aug 10, 2025

lib/utmp.c: Fix use of last utmp entry instead of patrial-match entry #1326

Merged

alejandro-colomar force-pushed the memdup branch from 903035d to ab7bb52 Compare August 11, 2025 20:32

alejandro-colomar mentioned this pull request Aug 11, 2025

ut-match algorithm improvements. #1333

Draft

alejandro-colomar added the Simpler A good issue for a new beginner label Aug 16, 2025

alejandro-colomar mentioned this pull request Sep 29, 2025

4.19 Release plan (H) #1354

Open

alejandro-colomar force-pushed the memdup branch from ab7bb52 to 06c665a Compare September 30, 2025 10:19

alejandro-colomar requested a review from ikerexxe October 7, 2025 19:25

alejandro-colomar force-pushed the memdup branch from 06c665a to 1b732db Compare October 19, 2025 09:19

alejandro-colomar force-pushed the memdup branch 3 times, most recently from 5aff45d to d7eb6b8 Compare October 29, 2025 16:33

alejandro-colomar added 3 commits October 29, 2025 17:34

lib/string/strdup/: memdup(), MEMDUP(): Add APIs

3ab394e

Signed-off-by: Alejandro Colomar <[email protected]>

lib/utmp.c: get_current_utmp(): Don't exit(3) from library code

d85dc78

This function already returned NULL on some errors. It didn't make any sense to exit(3) on allocation failure. Instead, just return NULL. Signed-off-by: Alejandro Colomar <[email protected]>

lib/utmp.c: get_current_utmp(): Use MEMDUP() instead of its pattern

a3f05ac

Cc: "Evgeny Grin (Karlson2k)" <[email protected]> Signed-off-by: Alejandro Colomar <[email protected]>

alejandro-colomar force-pushed the memdup branch from d7eb6b8 to a3f05ac Compare October 29, 2025 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add and use memdup(), MEMDUP(), instead of its pattern #1296

Add and use memdup(), MEMDUP(), instead of its pattern #1296

Uh oh!

alejandro-colomar commented Jul 16, 2025 •

edited

Loading

Uh oh!

Karlson2k commented Jul 18, 2025

Uh oh!

Karlson2k commented Jul 18, 2025

Uh oh!

alejandro-colomar commented Jul 18, 2025 •

edited

Loading

Uh oh!

Karlson2k commented Jul 18, 2025

Uh oh!

alejandro-colomar commented Jul 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add and use memdup(), MEMDUP(), instead of its pattern #1296

Are you sure you want to change the base?

Add and use memdup(), MEMDUP(), instead of its pattern #1296

Uh oh!

Conversation

alejandro-colomar commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Karlson2k commented Jul 18, 2025

Uh oh!

Karlson2k commented Jul 18, 2025

Uh oh!

alejandro-colomar commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Karlson2k commented Jul 18, 2025

Uh oh!

alejandro-colomar commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alejandro-colomar commented Jul 16, 2025 •

edited

Loading

alejandro-colomar commented Jul 18, 2025 •

edited

Loading

alejandro-colomar commented Jul 18, 2025 •

edited

Loading