Remove unused logoutd utility

[ikerexxe]

Link: #999

[alejandro-colomar]

Are there 0 users of this program?

[ikerexxe]

AFAIK, neither Debian nor Fedora or openSUSE provide this binary. So, yeah, I'd say nobody out there is using this binary.

[alejandro-colomar]

Thanks! LGTM then.

Reviewed-by: Alejandro Colomar <[email protected]>

CC: @thesamesam , @Karlson2k , just in case Gentoo has anything to say.

[ikerexxe]

Curious. I thought we had discussed this topic and decided to deprecate this utility and announced it in a release. I don't see any release announcement, so I'm fine with announcing the deprecation in the upcoming release and postponing the removal until the next one.

[hallyn]

@ikerexxe how should we announce it?

Putting it into the git log is probably the only way that I would remember to put it into release notes. So perhaps you should open a PR creating an API.md or DEPRECATIONS.md or something, put a dated note in there with a meaningful subject line on the git commit entry, and then the git shortlog will automatically put that into the release notes?

[ikerexxe]

@ikerexxe how should we announce it?

In the release notes.

Putting it into the git log is probably the only way that I would remember to put it into release notes. So perhaps you should open a PR creating an API.md or DEPRECATIONS.md or something, put a dated note in there with a meaningful subject line on the git commit entry, and then the git shortlog will automatically put that into the release notes?

I don't like this approach. When Alejandro opens the issue to create the new release I'll try to write this topic there.

[alejandro-colomar]

@ikerexxe how should we announce it?

In the release notes.

Putting it into the git log is probably the only way that I would remember to put it into release notes. So perhaps you should open a PR creating an API.md or DEPRECATIONS.md or something, put a dated note in there with a meaningful subject line on the git commit entry, and then the git shortlog will automatically put that into the release notes?

I don't like this approach. When Alejandro opens the issue to create the new release I'll try to write this topic there.

I've opened the release ticket. Feel free to add the deprecation notices there.

[zeha]

Should this also remove various references to (/etc/)porttime?

[zeha]

Should this also remove various references to (/etc/)porttime?

Doesn't seem super clear, maybe porttime and co wants to go away in a release after logoutd is removed.

[ikerexxe]

I wasn't aware of /etc/porttime, but from what I can see it isn't distributed in major distributions. I've added the deprecation to 4.19 Release plan (H).

What is this co that you mention? Any file I can check? If we aren't using it anywhere we should also remove it.

[zeha]

What is this co that you mention? Any file I can check? If we aren't using it anywhere we should also remove it.

Specifically I was refering to isttytime and port.[ch]. My understanding there is not complete, please check it.

[ikerexxe]

Those things that you mentioned are part of shadow's internal library and being used by other binaries apart from logoutd, so I think we'll keep using them (at least for the moment)