src/chgpasswd.c: fix handling of files without trailing newlines #1358
Conversation
Fix chgpasswd to properly handle input files that don't end with a newline, similar to how chpasswd handles this case. Previously, chgpasswd would incorrectly report "line too long" errors when processing the last line of a file that didn't end with a newline character. The fix adds proper end-of-file detection and long line handling logic consistent with chpasswd implementation. Signed-off-by: Iker Pedrosa <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * file (gshadow or group) and the password changed. | ||
| */ | ||
| while (fgets (buf, (int) sizeof buf, stdin) != NULL) { | ||
| char *cp; |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
I don't like handling files without a trailing newline. Those files are not POSIX conforming, and we should reject them. I strongly oppose this change, as it increases the complexity of the code unnecessarily. Instead files should be fixed to have a trailing line, which is simple to fix.
I want to remove that code, actually.
|
After reading this definition, I agree with you. I proceed to close the PR. |
Thanks! :-) |
2 participants
Fix chgpasswd to properly handle input files that don't end with a newline, similar to how chpasswd handles this case. Previously, chgpasswd would incorrectly report "line too long" errors when processing the last line of a file that didn't end with a newline character.
The fix adds proper end-of-file detection and long line handling logic consistent with chpasswd implementation.
I discovered this issue while developing
test_chgpasswd__change_passwords_from_filefrom #1357.