Rename array macro wrappers with an _a suffix instead of uppercase #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
_a
branch
2 times, most recently
from
fc23936 to
ab16bc2
Compare
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. Signed-off-by: Alejandro Colomar <[email protected]>
This name better reflects that it handles arrays, and doesn't shout. This case is slightly different, as this macro does a little bit more than just enforcing arrays. It changes the return value too. However, that is related-enough to the handling of arrays that I'm inclined to accept it as a minor inconsistency. Signed-off-by: Alejandro Colomar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: @hallyn
I wrote this to reduce your eye bleeding. :)
Queued after #1263 . (Done.)