lib/utmp.c: is_my_tty(): Simplify #1376
Open
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
mytty
branch
from
f68a208 to
568527e
Compare
alejandro-colomar
changed the title
alejandro-colomar
force-pushed
the
mytty
branch
2 times, most recently
from
b4a9595 to
be26914
Compare
alejandro-colomar
changed the title
alejandro-colomar
force-pushed
the
mytty
branch
5 times, most recently
from
b5249fb to
3c46edb
Compare
The method for checking for truncation was quite weird. By not caching ttyname(3), we use it directly, without needing a temporary copy, which removes opportunities for bugs. Signed-off-by: Alejandro Colomar <[email protected]>
This name makes the function definition more readable. Signed-off-by: Alejandro Colomar <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>
And use it instead of its pattern. This macro enforces correct use of ttyname_r(3) with arrays. Signed-off-by: Alejandro Colomar <[email protected]>
alejandro-colomar
force-pushed
the
mytty
branch
from
3c46edb to
993fc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's keep it simple.