Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebVTT): Fix display italic subtitles with end align #7559

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 7, 2024

Fixes #7553

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Nov 7, 2024
@avelad avelad added this to the v4.12 milestone Nov 7, 2024
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If you want to push to nightly to get confirmation from @Robloche, we can always revert before our next release if it's wrong.

@avelad avelad merged commit 781a27d into shaka-project:main Nov 7, 2024
16 of 17 checks passed
@avelad avelad deleted the vtt-italic branch November 7, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VTT italic subtitles badly displayed
2 participants