fix(CEA): cache and restore cea decoders based on the period continuity for dash content that uses SegmentTemplate #8378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arser on contiuinty timeline changes
|
Incremental code coverage: 100.00% |
avelad
requested changes
Apr 2, 2025
avelad
changed the title
avelad
added
type: bug
avelad
reviewed
Apr 22, 2025
tykus160
requested changes
Apr 22, 2025
Co-authored-by: Álvaro Velad Galván <[email protected]>
Co-authored-by: Wojciech Tyczyński <[email protected]>
tykus160
approved these changes
Apr 23, 2025
avelad
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where in SSAI content, 708 data was being split by ad periods. Currently, when this happens, we reset the 708 decoder, which means that captions are lost. Instead, we want to cache this decoder for a later time. This change keeps track of continuous periods and caches the 708 decoder when a period change happens to a discontinuous period. This is so that it could be later restored if we go back to a continuous period.