Skip to content

feat: Configurable ACL #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zachelrath
Copy link

This PR adds the ability to configure the ACL used when uploading objects via an "acl" parameter

@WoodyWoodsta
Copy link

Personally, I feel as though the default should not be anything public. Some user's may not catch this. Making uploaded content publicly accessible should be opt-in.

@zachelrath
Copy link
Author

@WoodyWoodsta Totally agree, but that would be a breaking change, and would need to be done in a major release. I was just preserving the previous default behavior. But I absolutely agree, this is why we need a configurable ACL for this action, defaulting content to be publicly-accessible makes this GH Action unusable for a lot of enterprise use cases, which is a shame because otherwise it is very helpful! I had to fork the repo just to configure a non-public ACL.

Doesn't seem like @shallwefootball is actively maintaining this repo either, so it may be a moot point, I submitted this PR 8 months ago.

@WoodyWoodsta
Copy link

I've resorted to a different action.

@zachelrath
Copy link
Author

@WoodyWoodsta Make sense, which other action are you using?

@WoodyWoodsta
Copy link

https://github.com/marketplace/actions/simple-s3-upload

Yet to test if it's working as expected, but the code is simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants