Skip to content

RFC: Add experimental CoreML delegate #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucyllewy
Copy link

@lucyllewy lucyllewy commented Feb 2, 2021

  • Update TensorFlowLiteC to TensorFlowLiteC/Core (version 2.4.0)
  • Add TensorFlowLiteC/Metal to restore Metal delegate after v2.4.0 moved
    it to a separate pod.
  • Add TensorflowLiteC/CoreML to add experimental CoreML delegate.

Due to being on an M1 mac, and the lack of Flutter support for the iOS simulator on M1, I'm unable to test this for sanity well yet. I'd appreciate comments and suggestions and wider testing.

@fotiDim
Copy link

fotiDim commented Mar 22, 2021

Using the CoreML delegate works 👍
Using the GPUDelegate gives me a crash through:

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x380e1802f)
    frame #0: 0x00000001051c5930 Runner`___lldb_unnamed_symbol11964$$Runner + 1672
Runner`___lldb_unnamed_symbol11964$$Runner:
->  0x1051c5930 <+1672>: str    w12, [x9, x11]
    0x1051c5934 <+1676>: ldr    x11, [x10, #0x8]
    0x1051c5938 <+1680>: cbz    x11, 0x1051c594c          ; <+1700>
    0x1051c593c <+1684>: mov    x10, x11
Target 0: (Runner) stopped.

* Update TensorFlowLiteC to TensorFlowLiteC/Core (version 2.4.0)
* Add TensorFlowLiteC/Metal to restore Metal delegate after v2.4.0 moved
  it to a separate pod.
* Add TensorflowLiteC/CoreML to add experimental CoreML delegate.
* Add documentation of  option.

Signed-off-by: Daniel Llewellyn <[email protected]>
@lucyllewy
Copy link
Author

@fotiDim sorry about the late reply. I pushed some code to attempt to fix your issue with GPUDelegate a while back but forgot to let you know about it - I've just rebased against the main branch to pick up the latest changes from @shaqian if you'd like to give it another pop...

Signed-off-by: Dani Llewellyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants