Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve coverage check logic and error reporting #48

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

shanejonas
Copy link
Collaborator

Fixes some issues with the coverage check in the shared ci config:

  • Remove redundant threshold comparison in coverage check
  • Fix floating point comparison using bc for accurate coverage evaluation
  • Improve error messages
  • Standardize terminology around "target coverage"
  • Remove unused THRESHOLD variable and checks

BREAKING CHANGE: Coverage check now only uses TARGET_COVERAGE input parameter,
removing the secondary threshold from jest.config.js

@shanejonas shanejonas requested a review from a team as a code owner March 3, 2025 21:08
@shanejonas shanejonas merged commit 21a1ec7 into dev Mar 3, 2025
7 checks passed
@shanejonas shanejonas deleted the fix/coverage-checks branch March 3, 2025 21:20
@shanejonas shanejonas restored the fix/coverage-checks branch March 12, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants