Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow PR QA checks on any branch #53

Closed
wants to merge 1 commit into from
Closed

fix: allow PR QA checks on any branch #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ on:
- main
pull_request:
branches:
- dev
- main
- '**'
Comment on lines 11 to +13
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Ensure that allowing PR QA checks on all branches does not inadvertently trigger workflows on branches that should be excluded, such as temporary or feature branches. [general, importance: 6]

Suggested change
pull_request:
branches:
- dev
- main
- '**'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just remove the dev and main, since ** will cover it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/implement

issue_comment:
inputs:
workflowBranch:
Expand Down
Loading