Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update shardeum package name and add linear linking instructions #63

Merged
merged 1 commit into from
Mar 17, 2025
Merged

fix: update shardeum package name and add linear linking instructions #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/reusable-node-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,14 @@ jobs:
pr_reviewer.extra_instructions: |
## Reviewer Instructions
### General
- In general if there is a PR that requires updating any versions of `@shardeum` packages, ensure those changes are in an separate PR (or in the same PR in its own commit). Otherwise, merging between branch lines (which have different versions) is much more difficult.
- In general if there is a PR that requires updating any versions of `@shardeum-foundation` packages, ensure those changes are in an separate PR (or in the same PR in its own commit). Otherwise, merging between branch lines (which have different versions) is much more difficult.
### Linear Integration
We should make sure that each PR is linked to a Linear issue.
- One of the following must be true:
- The PR description includes the Linear issue key (e.g. `SHARD-123`)
- The PR title includes the Linear issue key (e.g. `P1-123`)
- The PR branch name includes the Linear issue key (e.g. `P1-123`)
- The commit messages include the Linear issue key (e.g. `P1-123`)
### Unit Tests
- Ensure that external API calls or side effects are mocked out, not the function under test
- Each test should import the actual function being tested
Expand Down
Loading