SHARD-1950 - fix: gas calculation returns non hex #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
commented
Mar 7, 2025
shanejonas
commented
Mar 7, 2025
urnotsam
previously approved these changes
Mar 7, 2025
justin-shardeum
changed the title
|
Need to rebase your commits and make sure to sign them |
shanejonas
force-pushed
the
fix/gas-calc
branch
3 times, most recently
from
a063e8f to
570906f
Compare
shanejonas
force-pushed
the
fix/gas-calc
branch
from
570906f to
005c218
Compare
urnotsam
approved these changes
Mar 11, 2025
mhanson-github
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug while fixing/testing SHARD-1947 locally where its trying to add integers then transform it back to a string but didnt put it into hex, so it was returning gas: "0x21000". i can reproduce locally but not on itn4 rpc url.
fixes: https://linear.app/shm/issue/SHARD-1950/gas-calculation-on-json-rpc-server-should-return-appropriate-hex-value