SHARD-1947 fix gasPrice issue #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
changed the title
shanejonas
commented
Mar 7, 2025
| @@ -546,7 +546,7 @@ class Collector extends BaseExternal { | |||
| gas: '0x' + txObj.gasLimit.toString(16), | |||
| value: '0x' + txObj.value.toString('hex'), | |||
| input: '0x' + txObj.data.toString('hex'), | |||
| gasPrice: '0x' + txObj.getBaseFee().toString(16), | |||
There was a problem hiding this comment.
In the existing code:
getBaseFee() returns the min gas the tx must have, not the gas price.
urnotsam
previously approved these changes
Mar 7, 2025
aniketdivekar
previously approved these changes
Mar 7, 2025
mhanson-github
dismissed stale reviews from aniketdivekar and urnotsam
The base branch was changed.
mhanson-github
force-pushed
the
fix/gasprice-issue
branch
from
eac4fd9 to
2af301f
Compare
mhanson-github
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/shm/issue/SHARD-1947/fix-gasprice-in-the-rpc-response-add-a-field-for-gasused