SHARD-1932 - Remove redundant mem copies and fix socket bugs.#23
Merged
mhanson-github merged 3 commits intomainnet-launchfrom Mar 6, 2025
Merged
SHARD-1932 - Remove redundant mem copies and fix socket bugs.#23mhanson-github merged 3 commits intomainnet-launchfrom
mhanson-github merged 3 commits intomainnet-launchfrom
Conversation
optimized sender fixed 2 bugs with socket errors
mhanson-github
force-pushed
the
SHARD-1932
branch
from
1dd315e to
010c04e
Compare
mhanson-github
changed the title
mhanson-github
previously approved these changes
Mar 6, 2025
mhanson-github
left a comment
mhanson-github
left a comment
There was a problem hiding this comment.
Some good mem copy fixes and socket fixes in here. Like the changes.
abdulazeem-tk4vr
suggested changes
Mar 6, 2025
| @@ -65,9 +65,9 @@ impl ShardusNetSender { | |||
| let compressed_data = header.compress(data); | |||
There was a problem hiding this comment.
would be nice to remove this since we are also removing decompress
devendra-shardeum
requested changes
Mar 6, 2025
Author
|
added changes for multisend too |
Author
|
do not merge, testing |
mhanson-github
approved these changes
Mar 6, 2025
abdulazeem-tk4vr
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.